Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eslint rule #93

Open
jason89521 opened this issue Jun 24, 2023 · 0 comments
Open

add eslint rule #93

jason89521 opened this issue Jun 24, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@jason89521
Copy link
Owner

jason89521 commented Jun 24, 2023 •
edited

Which function need a rule:

  • useHydrate: should use the serverStateKey when using model.mutate
  • useAccessor: the props or state in getSnapshot function should also appear in the accessor creator
  • useModel: the getSnapshot function should be memoized by useCallback
@jason89521 jason89521 added the help wanted Extra attention is needed label Jul 5, 2023
@jason89521 jason89521 mentioned this issue Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jason89521