From 4029c1336bdf17f7074f36f6c5a1303520234e2d Mon Sep 17 00:00:00 2001 From: Jason Grout Date: Thu, 14 Nov 2019 08:16:24 -0800 Subject: [PATCH] Disable type checking vega-lite libraries. Typscript 3.7 throws some errors when compiling Vega-lite 2 and 3, so we turn off lib checks. This was investigated much more deeply in https://github.com/jupyterlab/jupyterlab/pull/7428, where we deleted the vega 4 extension and upgraded the vega 5 extension to vega-lite 4.0b11. The vega-lite upgrade was not going smoothly, so we moved it to a separate issue and redid the Typescript upgrade by just using the skipLibCheck flag. --- packages/vega4-extension/tsconfig.json | 1 + packages/vega5-extension/tsconfig.json | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/vega4-extension/tsconfig.json b/packages/vega4-extension/tsconfig.json index 68df27709c47..a631202393b1 100644 --- a/packages/vega4-extension/tsconfig.json +++ b/packages/vega4-extension/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfigbase", "compilerOptions": { "outDir": "lib", + "skipLibCheck": true, "types": ["webpack-env"], "rootDir": "src" }, diff --git a/packages/vega5-extension/tsconfig.json b/packages/vega5-extension/tsconfig.json index 68df27709c47..a631202393b1 100644 --- a/packages/vega5-extension/tsconfig.json +++ b/packages/vega5-extension/tsconfig.json @@ -2,6 +2,7 @@ "extends": "../../tsconfigbase", "compilerOptions": { "outDir": "lib", + "skipLibCheck": true, "types": ["webpack-env"], "rootDir": "src" },