Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file handling #500

Closed
jasonkuhrt opened this issue Apr 5, 2023 · 3 comments · Fixed by #501
Closed

Remove file handling #500

jasonkuhrt opened this issue Apr 5, 2023 · 3 comments · Fixed by #501

Comments

@lynxtaa
Copy link
Contributor

lynxtaa commented May 2, 2023

Sad to see it's gone but understandable. It was me who originally added a file upload feature to graphql-request #175 . If someone needs it I'm still maintaining https://www.npmjs.com/package/awesome-graphql-client which has a file upload support and I'm not planning to remove it

@haZya
Copy link

haZya commented May 17, 2023

Well, this wasted half a day of my life trying to figure out what was going wrong since the previous versions of this library supported file uploads. Maybe put something like a warning message on the console to indicate that the file handling is removed? This would help poor souls such as myself who are trying to use previously working code on a new project and pulling all their hair out not knowing what is blowing up. :)

@jasonkuhrt
Copy link
Owner Author

@haZya PR welcome

Repository owner locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants