fix: add support for TypedDocumentNode to be passed to WS methods #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, shoot - format seems to be broken. Apologies - I ran |
Hmm, I seem to see that there's a few files that need to be formatted that aren't related to my change. Should I commit them or leave it for a different PR? (which I'm happy to open) |
|
@crutchcorn a format would be welcome, that is from having merged some updates to prettier but I didn't re-format trunk yet. |
|
@crutchcorn Actually it's fine, nothing to do with you or this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TypedDocumentNodes to be passed to the
subscribeandrequestmethods of the WebSockets implementation.This allows the return type from
nextandvariablesto be properly typed when paired with @graphql-codegen/cliI have tested this change in my codebase and it appears to function as I would expect on the type level