Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover body is not centered over target #185

Open
trinile opened this issue Jul 18, 2018 · 5 comments
Open

Popover body is not centered over target #185

trinile opened this issue Jul 18, 2018 · 5 comments

Comments

@trinile
Copy link

trinile commented Jul 18, 2018

The popover body position is not consistent and hard to get it centered over the target (that is not moving).

@ruimigueldp
Copy link

ruimigueldp commented Jul 18, 2018

Its not centered when you choose above and below positions. But if you double click it, the body stay aligned with the tip. That is because when the Popover "wrapper" renders into the page for the very first time it has the property of flex-direction: row and calculates the width with the body and tip together. thats why its not centered. for above and below alignments, the flex direction should be column and for right and left row.

@ruimigueldp
Copy link

I notice that last week. this package has a lot of potential but seems abandoned

@trinile
Copy link
Author

trinile commented Jul 18, 2018

The popover seems to center properly in safari, but not in chrome.

@ruimigueldp
Copy link

yep I notice that too! wierd, right? I cant tell why.

@trinile
Copy link
Author

trinile commented Jul 18, 2018

@ruimigueldp thanks for the suggestion about the flex. I set the .Popover-below to flex-direction: column and that seemed to fix the centering issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants