Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to add this patch to this package to resolve the "moment-with-locales.js" path issue #195

Open
AThiyagarajan opened this issue Mar 29, 2023 · 1 comment

Comments

@AThiyagarajan
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch ember-cli-moment-shim@3.8.0 for the project I'm working on.

moment has changed the path for the 'moment-with-locales.js' file. It would be good if we have this fixed at the source level.

Here is the diff that solved my problem:

diff --git a/node_modules/ember-cli-moment-shim/index.js b/node_modules/ember-cli-moment-shim/index.js
index ea87353..29046e2 100644
--- a/node_modules/ember-cli-moment-shim/index.js
+++ b/node_modules/ember-cli-moment-shim/index.js
@@ -37,7 +37,7 @@ module.exports = {
 
     if (typeof options.includeLocales === 'boolean' && options.includeLocales) {
       this.import(
-        'vendor/moment/moment-with-locales.js',
+        'vendor/moment/min/moment-with-locales.js',
         { prepend: true }
       );
     } else {
@AThiyagarajan AThiyagarajan changed the title Fix needed for the "moment-with-locales.js" apth Would like to add this patch to this package to resolve the "moment-with-locales.js" path issue Mar 29, 2023
@AThiyagarajan
Copy link
Author

Created a PR with this fix.
#196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant