Support for Jetty 12

[johanhaleby]

It would be nice if Javalin would depend on Jetty 12. Currently, it's hard for us to upgrade to Spring Boot 3.2 because Javalin uses Jetty 11 and Spring Boot uses Jetty 12. It's not enough to just set the jetty.version property in Maven, because spring boot specifies a bom that doesn't exist in Jetty 11 (org.eclipse.jetty.ee10:jetty-ee10-bom:pom).

The workaround we have to do now is to specify each jetty dependency explicitly:

<dependency>
    <groupId>io.javalin</groupId>
    <artifactId>javalin</artifactId>
    <version>5.6.3</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-server</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-http</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-util</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-security</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-io</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>
<dependency>
    <groupId>org.eclipse.jetty</groupId>
    <artifactId>jetty-xml</artifactId>
    <version>${jetty-javalin.version}</version>
</dependency>

where jetty-javalin.version is specified to 11.0.17.

[tipsy]

@johanhaleby we discussed it, but ultimately decided against it because of the lack of a proper migration guide from Jetty. It's unclear how much work this is. Do you want to have a look at it?

[johanhaleby]

Oh, I didn't know this. There's a project in the JVM space that has "recipes" (or something similar) for automatically upgrading between different major versions of frameworks/libraries. Maybe they have a recipe for jetty? However, I don't remember the name of the project :)

[johanhaleby]

I was thinking of openrewrite, but I don't can't see that they have support for Jetty unfortunately.

[klassm]

Unfortunately downgrading the jetty version also does not work for me anymore, as Spring Boot also references org.eclipse.jetty.io.Content - which has not been present in Jetty 11.
Unfortunately this now means that Javalin is blocking any further Spring Boot updates -.-

[klassm]

By now there is also a migration guide: https://eclipse.dev/jetty/documentation/jetty-12/programming-guide/index.html#pg-migration-11-to-12

[tipsy]

Do you think you could submit a PR @klassm?

[klassm]

Not sure - I just tried to do the upgrade, but I get stuck at the micrometer upgrade. I am not even sure whether that is currently possible, as there is no micrometer-jetty12 dependency available. There's also an open issue about jetty12 support...
micrometer-metrics/micrometer#4261

[zhipengzuo]

hello, any process for Jetty 12? jetty 11 is end of support jetty/jetty.project#10485.
some issue like jetty/jetty.project#11362 must upgrade to jetty 12 .

[tipsy]

@zhipengzuo it's planned for Javalin7, but not before that.

[zhipengzuo]

@zhipengzuo it's planned for Javalin7, but not before that.

hi,what about the time of Javalin7 ,thanks

[tipsy]

No time set, hopefully end of the year :)