Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏫ Upgrade to Micrometer 1.13 #2248

Open
bogedal opened this issue May 16, 2024 · 5 comments
Open

⏫ Upgrade to Micrometer 1.13 #2248

bogedal opened this issue May 16, 2024 · 5 comments

Comments

@bogedal
Copy link

bogedal commented May 16, 2024

Describe the feature
Since Micrometer 1.13 introduces a few breaking changes and have deprecated io.micrometer.prometheus.PrometheusMeterRegistry I would like to see javalin-micrometer bumped to this version.

Additional context
The breaking changes in 1.13 can be see here Migration Guide

@tipsy
Copy link
Member

tipsy commented May 16, 2024

@bogedal You want to introduce breaking changes on the current (6x) branch?

@zugazagoitia
Copy link
Member

zugazagoitia commented May 16, 2024

Edit: nope we cannot

I have to say @tipsy I see the value in this, we could have an extra module for the newer micrometer until 7.x then drop the old one?

@zugazagoitia
Copy link
Member

Let's add a Javalin 7 tag and let it age like wine until we bump to jetty12

@tipsy
Copy link
Member

tipsy commented Jun 1, 2024

Hm.. I accidentally merged this from dependabot because the tests passed 🤔

@zugazagoitia
Copy link
Member

Well we should check our tests and potentially revert the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants