Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme: mention to replace HttpLink with createUploadLink #247

Closed
bruvers opened this issue Feb 27, 2021 · 2 comments
Closed

Update Readme: mention to replace HttpLink with createUploadLink #247

bruvers opened this issue Feb 27, 2021 · 2 comments

Comments

@bruvers
Copy link

bruvers commented Feb 27, 2021

The current Readme mentions that any HttpLink links should be removed from ApolloClient. This makes it sound like blocking requirement for some even though createUploadLink can be used to do a similar job that HttpLink did.

I suggest to update the Readme and mention that createUploadLink has similar features as HttpLink and can in many cases replace it.

@jaydenseric
Copy link
Owner

jaydenseric commented Mar 1, 2021

Agreed.

The repo about text and package description says:

A terminating Apollo Link for Apollo Client that allows FileList, File, Blob or ReactNativeFile instances within query or mutation variables and sends GraphQL multipart requests.

That sounds like it only sends multipart requests. In reality it automatically sends either normal GET/POST requests, or multipart requests when files are used in variables.

I'm really busy on other OSS work, but next time I do some maintenance here I'll improve the wording :)

@jaydenseric
Copy link
Owner

Thanks for the input; this should be much clearer now in v15 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants