Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use one common function to resolve callable objects #1068

Open
hirotasoshu opened this issue May 29, 2023 · 1 comment
Open

Refactor: use one common function to resolve callable objects #1068

hirotasoshu opened this issue May 29, 2023 · 1 comment

Comments

@hirotasoshu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment there is duplicate code in many places that resolves callable objects from string path or object itselfs and it would be nice to clean that up

Describe the solution you'd like
Create one common function to resolve callable objects

Describe alternatives you've considered
None

Additional context
Proposed by @aleksihakli in #1058 (comment)

@aleksihakli
Copy link
Member

aleksihakli commented Jun 13, 2023

This would be a nice update to clean up the current code, and possibly to reduce the required unit test scope as well. Refactoring the resolvers could possibly enable refactoring the tests a bit in the same go. Could maybe be good to refactor the current resolvers first, and maybe open a separate PR on the test refactoring afterwards, if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants