Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None annotation for __init__ constructors/functions #186

Merged
merged 1 commit into from Jun 1, 2022
Merged

None annotation for __init__ constructors/functions #186

merged 1 commit into from Jun 1, 2022

Conversation

ShobanChiddarth
Copy link
Contributor

@ShobanChiddarth ShobanChiddarth commented Jun 1, 2022

Everywhere there was a class declaration and a init function
defined for that class, I added None as an annotation to it.

class ...:
    def __init__(..) -> None:

Reason

Everywhere there was a class declaration and a __init__ function
defined for that class, I added `None` as an `annotation` to it.

Reason: https://peps.python.org/pep-0484/#the-meaning-of-annotations
@ShobanChiddarth ShobanChiddarth changed the title Added None annotation to __init__ constructors None annotation for __init__ constructors/functions Jun 1, 2022
@hugovk hugovk added the changelog: Fixed For any bug fixes label Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #186 (1470440) into master (01e8eb2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.02%     
==========================================
  Files           5        5              
  Lines        2295     2287       -8     
==========================================
- Hits         2160     2153       -7     
+ Misses        135      134       -1     
Flag Coverage Δ
macos-latest 94.14% <100.00%> (+0.02%) ⬆️
ubuntu-latest 94.14% <100.00%> (+0.02%) ⬆️
windows-latest 94.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prettytable/colortable.py 100.00% <100.00%> (ø)
src/prettytable/prettytable.py 90.39% <100.00%> (ø)
tests/test_prettytable.py 100.00% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e8eb2...1470440. Read the comment docs.

@ShobanChiddarth
Copy link
Contributor Author

image
3 Checks have failed. Is there anything wrong? Is there anything I still have to change?

@hugovk hugovk merged commit 4345954 into jazzband:master Jun 1, 2022
@ShobanChiddarth
Copy link
Contributor Author

@hugovk

Anyway, it's not a problem for this PR, let's just merge it. Thanks for the contribution!

Welcome. Regards.

@ShobanChiddarth ShobanChiddarth deleted the init-annotations branch June 1, 2022 13:48
@hugovk hugovk changed the title None annotation for __init__ constructors/functions None annotation for __init__ constructors/functions Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants