Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify line break character used in pagination #193

Merged
merged 2 commits into from Aug 21, 2022

Conversation

myheroyuki
Copy link
Contributor

In some cases when getting multiple pages of table data it's preferable to have the pages divided by breaks other than form feed. This allows users to separate pages by whatever they'd like.

@myheroyuki myheroyuki added the changelog: Added For new features label Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #193 (d4867a2) into master (27017ef) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.03%     
==========================================
  Files           5        5              
  Lines        2295     2290       -5     
==========================================
- Hits         2160     2156       -4     
+ Misses        135      134       -1     
Flag Coverage Δ
macos-latest 94.14% <100.00%> (+0.03%) ⬆️
ubuntu-latest 94.14% <100.00%> (+0.03%) ⬆️
windows-latest 94.01% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prettytable/prettytable.py 90.39% <100.00%> (ø)
tests/test_prettytable.py 100.00% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion for the test. Thanks!

tests/test_prettytable.py Show resolved Hide resolved
@hugovk hugovk merged commit 3859de2 into jazzband:master Aug 21, 2022
@hugovk
Copy link
Member

hugovk commented Aug 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants