Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to remove a spinner from the spinners list #5

Open
jbcarpanelli opened this issue Jun 5, 2019 · 4 comments
Open

Add ability to remove a spinner from the spinners list #5

jbcarpanelli opened this issue Jun 5, 2019 · 4 comments
Labels
feature New feature or request good first issue Good for newcomers
Milestone

Comments

@jbcarpanelli
Copy link
Owner

jbcarpanelli commented Jun 5, 2019

The idea is to implement a new method called remove that receives a spinner reference name as argument and removes that spinner from the list, and thus should not be printed again in the terminal If no reference is given, the method call does nothing.

Example usage:

const spinnies = new Spinnies();
spinnies.add('spinner-1');
spinnies.add('spinner-2');
spinnies.add('spinner-3');
setTimeout(() => {
  spinnies.remove('spinner-2');
}, 3000); // => should remove the second spinner and not print it again. 
@jbcarpanelli jbcarpanelli added the feature New feature or request label Jun 5, 2019
@jbcarpanelli jbcarpanelli added this to the v0.4.0 milestone Jun 5, 2019
@jbcarpanelli jbcarpanelli added the good first issue Good for newcomers label Jun 5, 2019
@SweetMNM
Copy link

SweetMNM commented Aug 8, 2019

I implemented this feature in my fork.
I'm working on more features, then i will open a PR.

@jbcarpanelli
Copy link
Owner Author

Hey @SweetMNM! Thanks for tackling this! Looking forward to reviewing that PR 🙂

@jbcarpanelli
Copy link
Owner Author

Hey @SweetMNM, I noticed you have been improving spinnies a lot in your fork! Do you plan to create a PR soon?

@SweetMNM
Copy link

Yes, I just want to finish implementing custom statuses, hide and unhide spinners, write some more tests and maybe some other features before I open the PR..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants