Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsTable#print needs to be extracted in a separate class #54

Closed
gvlasov opened this issue Jul 31, 2015 · 10 comments
Closed

AwsTable#print needs to be extracted in a separate class #54

gvlasov opened this issue Jul 31, 2015 · 10 comments

Comments

@gvlasov
Copy link
Contributor

gvlasov commented Jul 31, 2015

AwsTable#print is a pubilc static method that operates on public methods of its argument ConsumedCapacity. It could be made into an instance method of PrintableConsumedCapacity class, so we have one less public static method in our codebase.

@dmarkov
Copy link

dmarkov commented Aug 4, 2015

@yegor256 please pay attention to this issue

@yegor256
Copy link
Member

yegor256 commented Aug 4, 2015

@Suseika good catch, thanks

@dmarkov
Copy link

dmarkov commented Aug 4, 2015

@suseika many thanks for the bug report, I added 15 mins to your acc, transaction AP-87Y22228UH650533B

@dmarkov
Copy link

dmarkov commented Sep 9, 2016

@prondzyn please help, the task is yours

@prondzyn
Copy link
Contributor

prondzyn commented Sep 9, 2016

@dmarkov PR #82 prepared

@dmarkov
Copy link

dmarkov commented Sep 12, 2016

@dmarkov PR #82 prepared

@prondzyn thanks

@prondzyn
Copy link
Contributor

@dmarkov need more time. Still waiting on @yegor256 's merge in #82

@dmarkov
Copy link

dmarkov commented Sep 19, 2016

@dmarkov need more time. Still waiting on @yegor256 's merge in #82

@prondzyn agreed, take your time

@prondzyn
Copy link
Contributor

prondzyn commented Sep 23, 2016

@Suseika please close the task (it is done and merged)

@gvlasov gvlasov closed this as completed Sep 23, 2016
@dmarkov
Copy link

dmarkov commented Sep 27, 2016

@prondzyn paid, thanks, added 30 mins to your account, payment AP-2RA22125EF354472T, 407 hours and 19 mins was spent... +30 to your rating, your total score is +30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants