Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in AttributeUpdates.containsValue(Object) #80

Open
amihaiemil opened this issue Aug 24, 2016 · 1 comment
Open

Bug in AttributeUpdates.containsValue(Object) #80

amihaiemil opened this issue Aug 24, 2016 · 1 comment

Comments

@amihaiemil
Copy link
Member

Method containsValue() from this class should apply the same logic as with(String, Object) before calling this.attrs.containsValue(value)

This is because currently this test

AttributeUpdates attr = new AttributeUpdates() .with("key", "someString");
MatcherAssert.assertThat(
       attr.containsValue("someString),
       Matchers.is(Boolean.TRUE)
);

fails. In order for the containsValue() to return true, the client has to wrap the original value in an AttributeValue and so on (like it is wrapped inside with(String, Object.

After the fix, unit test AttributeUpdatesTest.containsValue() should also be fixed (currently it does the above mentioned "hack" to work).

@dmarkov
Copy link

dmarkov commented Aug 29, 2016

@yegor256 please do something about this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants