Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors broken with UnoCSS v0.57 #216

Open
hermit99 opened this issue Nov 2, 2023 · 7 comments
Open

Colors broken with UnoCSS v0.57 #216

hermit99 opened this issue Nov 2, 2023 · 7 comments

Comments

@hermit99
Copy link

hermit99 commented Nov 2, 2023

Looks like with UnoCSS v0.57.0's breaking changes, Anu's hsla colors are also broken.

Could we align and keep hsla and rgba consistent with tailwindcss too?

@jd-solanki
Copy link
Owner

Hi @hermit99

Sorry to say but I don't have enough bandwidth to work on this anymore. Feel free to submit a PR I'll surely merge it.

Thanks for raising the issue.

@hermit99
Copy link
Author

hermit99 commented Nov 9, 2023

Hi @jd-solanki PR 218 raised for your review.
Please be aware that this will be a breaking change version once merged, due to UnoCSS's underlying changes.

@jingyuexing
Copy link

image
the text color:

.text-primary {
    --un-text-opacity: 1;
    color: hsl(var(--a-primary) / var(--un-text-opacity));
}

But such css cannot be parsed correctly. The following code is the code that can be parsed correctly.

.text-primary {
    --un-text-opacity: 1;
    color: hsl(var(--a-primary) , var(--un-text-opacity));
}

image

@jingyuexing
Copy link

@jd-solanki

@hermit99
Copy link
Author

Depending on how --a-primary is defined, it's safer to use hsla() in such cases:

.text-primary {
    --un-text-opacity: 1;
    color: hsla(var(--a-primary), var(--un-text-opacity));
}

That's what #219 was trying to fix anyway.

@SoCuul
Copy link

SoCuul commented Jan 18, 2024

@jd-solanki Would it be possible to merge this in? I'm currently having issues with the library trying to resolve this.

@SoCuul
Copy link

SoCuul commented Jan 18, 2024

I'd also like to add that this is genuinely the best component library I've ever used. The simplicity of it while looking incredible has made it genuinely amazing to develop with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants