Fix NPE for Slf4JSqlLogger#logAfterExecution #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
approved these changes
Feb 17, 2022
StatementContext for Batch does not have ParsedSql. Both logAfterExecution and logException checks whether StatementContext#getParsedSql returns null or not to avoid an NPE.
tmichel
force-pushed
the
fix-slf4jsqllogger
branch
from
0e4db87
to
07228b0
Compare
|
I fixed the unused import error. What else do you need to get this merged? |
stevenschlansker
added a commit
that referenced
this pull request
Feb 18, 2022
|
Thanks @tmichel , released as 3.27.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NPE issue (#1961) during logging has already come up but the fix (0017222) only addressed the NPE for
logExceptionand not forlogAfterExecution.I extracted getting the SQL string from the
StatementContextinto a helper method. I opted for not using an Optional and rather use a conditional.There were no tests for
Slf4JSqlLoggerso I added some that reproduced the issue. I opted to not write a comprehensive test suite to keep the pull request more focused.