New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JTS PostGIS data type support #2074
Conversation
@bchapuis, please review |
e07a76f
to
da94a21
Compare
@hgschmie Thanks a lot for your help and for the changes, the dedicated module looks good! As mentionned in #2072, I'd love to appear in the commit history for this contribution. I can either cherry pick your last commit in my fork, or you can add me as a co-author in your commit. Either way is fine for me, let me know what you prefer.
|
da94a21
to
85d34d7
Compare
Support for Postgres PostGIS with the Eclipse LocationTech JTS Topology Suite. Supports mapping of all LocationTech data types onto PostGIS and back. Co-Authored-By: Bertil Chapuis <bchapuis@gmail.com>
85d34d7
to
9fcc642
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I added you as co-author (and you show up in the commit history). We really appreciate the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for the contribution!
|
||
static { | ||
if (System.getProperty("PG_FULL_IMAGE") == null) { | ||
System.setProperty("PG_FULL_IMAGE", "postgis/postgis:13-3.2-alpine"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that setting this property here affects other tests that might run after? That could introduce test instability depending on order of execution.
@Override | ||
public ColumnMapper<Geometry> getColumnMapper() { | ||
return (resultSet, index, context) -> { | ||
byte[] bytes = hexStringToByteArray(resultSet.getString(index)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to get the byte[]
directly via getBytes
?
Support for Postgres PostGIS extension. Based on code by @bchapuis