prefer setter annotations over getter annotations #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgschmie
force-pushed
the
fix-annotation-order
branch
2 times, most recently
from
2af7db5
to
4e34e7c
Compare
As all of the mappers deal with mapping data onto beans (which they use the setters for), they should also prefer the annotations found on the setter over the annotations on the getter. This PR also splits the very unwieldy and confusing BeanMapperTest into three separate tests, one focusing on general bean mapper properties, one for the PropagateNullable tests and one for Nested tests.
hgschmie
force-pushed
the
fix-annotation-order
branch
from
4e34e7c
to
be553b7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stevenschlansker
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all of the mappers deal with mapping data onto beans (which they use the setters for), they should also prefer the annotations found on the setter over the annotations on the getter.
This PR also splits the very unwieldy and confusing BeanMapperTest into three separate tests, one focusing on general bean mapper properties, one for the PropagateNullable tests and one for Nested tests.