fix(generator): return latest supported SourceVersion instead of 8

[Proximyst]

Fixes #2127.

We should be able to output generated code for any supported releases >= 8. Considering the bytecode we output for the artifact (i.e. the processor, not the generated code) is always Java 8 or newer as of writing, this will not be an issue.

We return the latest supported version for javac instead of the lowest version we expect to support, because javac will print warnings in that case. This breaks -Werror builds on versions higher than this is made to support (i.e. Java 9+ as of writing).

Legal note: this code is submitted under the applicable licence(s) (Apache 2.0, Jan 2004) with the ownership retained as Spotify AB.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[hgschmie]

Hi @Proximyst! Thank you for contributing to the JDBI project! The PR looks good to me; I kicked off the CI builds, if they pass I will merge this.

[hgschmie]

@Proximyst is the Legal note: this code is submitted under the applicable licence(s) (Apache 2.0, Jan 2004) with the ownership retained as Spotify AB. needed for you to contribute to the project? While we do not collect CLAs, we might need at some point, so this implies that you are allowed to grant us a license similar to the one laid out in https://www.apache.org/licenses/icla.pdf (the Apache contributor license agreement).

[Proximyst]

@hgschmie Needed and needed... it needs to be made clear that the company owns the code, but that we open for use in all the clauses that the licence lays out.

I'm more than happy to look into what you (the JDBI org) and I need to do to get a CLA signed, if you folks prefer that?

[hgschmie]

I think we are good. This git thread suffices for me.