Implement @RegisterCollector with tests and short doc #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
registercollector
branch
from
9c8e13c
to
3509081
Compare
stevenschlansker
force-pushed
the
registercollector
branch
from
3509081
to
c54e62e
Compare
|
thank you so much, have had no time lately my only thought that I was hopefully gonna get around to - would it be better to use a CollectorSupplier kind of class in the annotation? |
|
Kudos, SonarCloud Quality Gate passed!
|
hgschmie
requested changes
Jun 9, 2023
| @@ -4636,7 +4636,14 @@ the `User.id` and `User.name` fields. Likewise for `r_id` and `r_name` into the | |||
| The link:{jdbidocs}/sqlobject/config/RegisterConstructorMapper.html[@RegisterConstructorMapper^] annotation may be repeated multiple times on | |||
| the same type or method to register multiple constructor mappers. | |||
|
|
|||
| ==== @RegisterCollectorFactory | |||
There was a problem hiding this comment.
I think this would be a better fit after @UseRowReducer. The docs are so bare bones that, without an example, this will probably not find any users.
|
I will merge this and then fix the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the PR and hopefully got it over the finish line with a test and some simple docs.
Bonus fix: try to use the Collector's declared element type, so that you may collect into things that aren't
Iterables.Fixes #2357