Remove JSR 305 annotations #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
requested changes
Jun 27, 2023
|
replaced custom annotation with jakarta. |
The findbugs jsr305 annotations jar uses annotations in the javax.annotation namespace, which causes problems with JPMS. Remove the annotations from the code base. The Jdbi code itself transitions to error prone and spotbugs. For code that uses Jdbi (and all tests), the Jakarta annotation-api `jakarta.annotation.Nullable` is used as other candidates either do not have Runtime retention (spotbugs, jetbrains), have problems with JPMS (jsr305), or are very specialized (spring) or obscure (checker framework).
|
Kudos, SonarCloud Quality Gate passed!
|
stevenschlansker
added a commit
that referenced
this pull request
Aug 7, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
stevenschlansker
added a commit
that referenced
this pull request
Aug 7, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
stevenschlansker
added a commit
that referenced
this pull request
Aug 7, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
stevenschlansker
added a commit
that referenced
this pull request
Aug 7, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
stevenschlansker
added a commit
that referenced
this pull request
Aug 9, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
stevenschlansker
added a commit
that referenced
this pull request
Aug 9, 2023
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The findbugs jsr305 annotations jar uses annotations in the
javax.annotation namespace, which causes problems with JPMS.
Remove the annotations from the code base. The Jdbi code itself
transitions to error prone and spotbugs.
For code that uses Jdbi (and all tests), a new
annotation (org.jdbi.v3.core.mapper.reflect.Nullable) is introduced as
all candidates either do not have Runtime retention (spotbugs,
jetbrains), have problems with JPMS (jsr305), are very
specialized (spring) or obscure (checker framework).