move method reflection from ExtensionFactoryDelegate to ExtensionMetadata #2414

stevenschlansker · 2023-06-29T02:25:53Z

hgschmie · 2023-06-30T04:58:22Z

Turns out that there is actually a lot of stupidity in the original code. An interface can not override any method from Object (because ... rules). So all of the tests can go away, because we only create the metadata for interfaces.

…data fixes #2413

stevenschlansker · 2023-06-30T17:05:54Z

core/src/main/java/org/jdbi/v3/core/extension/ExtensionHandler.java

@@ -44,6 +45,15 @@ public interface ExtensionHandler {
    /** Handler that only returns null independent of any input parameters. */
    ExtensionHandler NULL_HANDLER = (handleSupplier, target, args) -> null;

+    /** Constant for {@link Object#equals(Object)}. */
+    Method EQUALS_METHOD = JdbiClassUtils.methodLookup(Object.class, "equals", Object.class);


I originally had these in JdbiClassUtils in order to have them not be part of the public API. Do we really want to ship this as part of public API?

stevenschlansker · 2023-06-30T17:06:34Z

core/src/main/java/org/jdbi/v3/core/extension/ExtensionMetadata.java

+     * Returns a reference to a method that overrides {@link Object#finalize()} if it exists.
+     * @return An {@link Optional} containing a {@link Method} if a finalizer exists.
+     */
+    public Optional<Method> getFinalizer() {


I originally had this as package-private so it is not part of the public API.
Do we really think this should be a fully supported part of the public API?

Interfaces can not override any method from Object and the extension metadata is only created for interfaces. So there is no need to do any checking. Rip out all of the check logic, add constant methods (except for toString). Cache the finalizer if present in extension metadata.