Improve config customizer performance #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
approved these changes
Jun 29, 2023
|
any chance you can test this before merging it? I want to make sure it actually has benefits. |
hgschmie
force-pushed
the
sqlobject-performance
branch
from
efdd491
to
914a59f
Compare
Allow config customizers that do not need the config object itself to create internal state at metadata creation time and cache that state as part of the extension type metadata. This moves the creation of a class (and potentially other expensive operations) away from the invocation of extension methods.
hgschmie
force-pushed
the
sqlobject-performance
branch
from
914a59f
to
f4df5c7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
hgschmie
added a commit
to hgschmie/jdbi
that referenced
this pull request
Jul 1, 2023
Apply the patterns from jdbi#2416 to all the remaining configurers.
hgschmie
added a commit
to hgschmie/jdbi
that referenced
this pull request
Jul 1, 2023
Apply the patterns from jdbi#2416 to all the remaining configurers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow config customizers that do not need the config object itself to
create internal state at metadata creation time and cache that state as
part of the extension type metadata. This moves the creation of a
class (and potentially other expensive operations) away from the
invocation of extension methods.