Make caches for row and column mappers smarter #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a mapper factory can report a type that it supports (the inferred factories and the static `...of()` mappers do as well), only invalidate a single cache entry, not the whole cache. This preserves elements that have been registered on the handle or the jdbi ifself when using with sqlobject @RegisterColumnMapper and @RegisterRowMapper annotations Self-rolled factories can implement the `getType()` method on the RowMapper and ColumnMapper interfaces to benefit from this as well.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Not really effective, shelving this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mapper factory can report a type that it supports (the inferred
factories and the static
...of()mappers do as well), only invalidatea single cache entry, not the whole cache.
This preserves elements that have been registered on the handle or the
jdbi ifself when using with sqlobject @RegisterColumnMapper and
@RegisterRowMapper annotations
Self-rolled factories can implement the
getType()method on theRowMapper and ColumnMapper interfaces to benefit from this as well.