Json plugin: do json type resolution during prepare stage #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
json-bind-type
branch
3 times, most recently
from
f76f54f
to
24f8f90
Compare
hgschmie
approved these changes
Jun 30, 2023
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.ArgumentMatchers.any; |
There was a problem hiding this comment.
I rather dislike that mocks make your tests depend on exactly what methods are called in what order, rather than the actual behavior of the implementation...
stevenschlansker
force-pushed
the
json-bind-type
branch
from
24f8f90
to
3d395fe
Compare
…ts and column mappers This allows type lookup and object reader / writer to be reused
stevenschlansker
force-pushed
the
json-bind-type
branch
from
3d395fe
to
8364511
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for arguments and column mappers
This allows type lookup and object reader / writer to be reused