Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapToFactory: reuse a single ResultReturner #2436

Merged
merged 1 commit into from Jul 13, 2023
Merged

MapToFactory: reuse a single ResultReturner #2436

merged 1 commit into from Jul 13, 2023

Conversation

stevenschlansker
Copy link
Member

rather than re-creating it each time

Inspecting methods is relatively expensive and they don't change.

@stevenschlansker stevenschlansker requested a review from a team July 13, 2023 17:07
@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

hgschmie
hgschmie approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@hgschmie hgschmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you checked that "result returners should be stateless" is true for all returners that we ship.

@stevenschlansker
Copy link
Member Author

Yes, I did.

@stevenschlansker stevenschlansker merged commit 8f74600 into master Jul 13, 2023
36 checks passed
@stevenschlansker stevenschlansker deleted the mapto-reuse-returner branch July 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hgschmie hgschmie hgschmie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevenschlansker @hgschmie