Generator: improve performance of creating instances #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
generator-ctor-mh
branch
from
7f889db
to
980354c
Compare
|
this should benefit from #2441 as well. |
Right now, every time you call attach or onDemand we repeatedly lookup the class and methods we use to construct them. Now, hold a cache of the lookups so we can re-use them.
hgschmie
force-pushed
the
generator-ctor-mh
branch
from
980354c
to
5869745
Compare
Use the new code from #2441 to improve Sql generator method lookup and on demand attachment.
hgschmie
force-pushed
the
generator-ctor-mh
branch
from
5869745
to
ea2876f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
hgschmie
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, every time you call attach or onDemand we repeatedly lookup the class and methods we use to construct them. Now, hold a cache of the lookups so we can re-use them.