OnDemandExtensions: flatten stack a bit by inlining Unchecked #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
ondemand-flatten
branch
7 times, most recently
from
495e1f5
to
34e1b93
Compare
We call Unchecked three times, and this ends up adding a number of stack frames in the debugger or profiler any time you are looking at an ondemand sqlobject This fights back just a little bit against ever-deepening stack traces, and makes the logic easier to read too without the distracting Unchecked signatures in the middle
stevenschlansker
force-pushed
the
ondemand-flatten
branch
from
34e1b93
to
d8ba280
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call Unchecked three times, and this ends up adding a number of stack frames in the debugger or profiler any time you are looking at an ondemand sqlobject
This fights back just a little bit against ever-deepening stack traces, and makes the logic easier to read too without the distracting Unchecked signatures in the middle