New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any Plans to Support Java Modules? #2368
Comments
Hi @SentryMan, Thank you for opening an issue with the Jdbi project. We have basic module support with We don't really worry about Java 8 support; we put that on notice a long time ago so moving past Java 8 will happen at some point. |
Module time? |
We would love to have module support - if you want to hack on it and start helping the project move to full module support, we'd definitely be here to help. The maintainers are interested in this feature but it's not something we're actively working on right now. |
Alrighty then, I can add the modules if the build is using JDK 11 |
I tried to give it a go but it seems I can't run the unchanged project tests on my local. Getting a ton of errors like these.
|
Hi @SentryMan , do you use Eclipse? I have seen this too, I suspect it is an For now, you can just skip those failing tests, although we should definitely figure out what is going wrong. |
Alternately, a |
was running |
I think |
also yes I do use eclipse |
figured it out, nvm |
I will try to create a test case to submit to Eclipse to hope it gets fixed eventually. |
so the only question I have then is what ServiceLoader interfaces do you guys use? |
I think Also, I filed: eclipse-jdt/eclipse.jdt.core#1267 |
I'd be great if JDBI supplied full Java module descriptors. This would allow modular project to create application images, as jlink only support explicit module-infos.
If you're worried about Java 8 support, It's possible to keep bytecode baseline compatible with Java 8 while providing a full module descriptor thanks to ModiTect.
The text was updated successfully, but these errors were encountered: