Remove findbugs annotations #2456
Conversation
stevenschlansker
force-pushed
the
scs-jakarta-annos
branch
2 times, most recently
from
dd1a3a6
to
c337ba6
Compare
There was a problem hiding this comment.
The code in the PR replaces annotations from the spotbugs-annotations jar, not the findbugs jsr305 jar. That was eliminated in #2408.
While it good to do so, the PR also needs to remove the jar references.
I am ok with the PR but it needs to get updated to remove the spotbugs-annotation references.
It may also make sense to add a section to the build pom akin to the basepom:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredDependencies combine.children="append">
<ignoredDependency>jakarta.annotation:jakarta.annotation-api</ignoredDependency>
</configuration>
</plugin>| @@ -18,7 +18,8 @@ | |||
| import java.util.stream.Collectors; | |||
| import java.util.stream.StreamSupport; | |||
|
|
|||
| import edu.umd.cs.findbugs.annotations.NonNull; | |||
|
|
||
| import edu.umd.cs.findbugs.annotations.NonNull; | ||
| import edu.umd.cs.findbugs.annotations.Nullable; |
|
actually never mind, it seems I have unlearned on how to read diffs. :-) All good. The exclusion block would still be good. |
core/src/main/java/org/jdbi/v3/core/interceptor/JdbiInterceptionChainHolder.java
Outdated
Show resolved
Hide resolved
As discussed in #2408, we should prefer the `jakarta` annotations, but that's not what actually got committed here. So clean that up
|
Why should we add a dependency ignore to the checker plugin? It passes the plugin checks fine right now. |
stevenschlansker
force-pushed
the
scs-jakarta-annos
branch
from
c337ba6
to
6dccc27
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
As discussed in #2408, we should prefer the
jakartaannotations, but that's not what actually got committed here. So clean that up