Fix regression for #2481 #2499
Merged
Fix regression for #2481 #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was highlighted that the change in 3.41.2 swallowed `-` characters at the end of named parameters and break expressions such as `:foo->>'stuff'`. - Rework the grammar to not support `-` as the last character. - Align the HashStatementLexer to the ColonStatementLexer - Add tests This addresses jdbi#2481 (comment)
hgschmie
force-pushed
the
regression-2481
branch
from
2013c6a
to
316ef21
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stevenschlansker
approved these changes
Oct 2, 2023
hgschmie
added a commit
to hgschmie/jdbi
that referenced
this pull request
Oct 24, 2023
This hopefully addresses all the issues raised in jdbi#2481, jdbi#2499 and finally jdbi#2510. The case of the trailing '-' is not solvable without a trailing delimiter. There is not enough information to decide whether `:foo-bar` is "identifier 'foo-bar'" or "identifier 'foo' minus bar". This PR drops the '-' again as a valid character in a parameter or binding (sorry if you added it; but then again this was only added in 3.41.1). The dot (`.`) is still supported as a valid character in a binding or parameter name. It always was for the parameters but not for a binding (this caused the original jdbi#2481 issue).
hgschmie
added a commit
to hgschmie/jdbi
that referenced
this pull request
Nov 19, 2023
This hopefully addresses all the issues raised in jdbi#2481, jdbi#2499 and finally jdbi#2510. The case of the trailing '-' is not solvable without a trailing delimiter. There is not enough information to decide whether `:foo-bar` is "identifier 'foo-bar'" or "identifier 'foo' minus bar". This PR drops the '-' again as a valid character in a parameter or binding (sorry if you added it; but then again this was only added in 3.41.1). The dot (`.`) is still supported as a valid character in a binding or parameter name. It always was for the parameters but not for a binding (this caused the original jdbi#2481 issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was highlighted that the change in 3.41.2 swallowed
-characters at the end of named parameters and break expressions such
as
:foo->>'stuff'.-as the last character.This addresses #2481 (comment)