Improvements on spring Jdbi repositories #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgschmie
approved these changes
Nov 20, 2023
docs/src/adoc/index.adoc
Outdated
| @@ -7333,6 +7332,10 @@ To use this module, add a Maven dependency: | |||
| </dependency> | |||
| ---- | |||
|
|
|||
| ==== XML-based configuration | |||
| For XML-based configurations the class `JdbiFactoryBean` is made available to set up a | |||
There was a problem hiding this comment.
could we use a link here as well?
docs/src/adoc/index.adoc
Outdated
| } | ||
| } | ||
| ---- | ||
| <1> This connection factory will enable <<jta, JTA support>>. |
There was a problem hiding this comment.
I read this as an anchor to the general JTA documentation, not spring-jta. Could we make this spring-jta ?
There was a problem hiding this comment.
I will, but the difference is small. JTA is an API and Spring JTA is the spring implementation of this API
|
I will take a look at the review comments |
|
LMK when you are done; I am planning to do a 3.42.0 release (the Kotlin coroutine stuff and the spring improvements are sufficient for a new release) now that the tests are stable again. |
stevenschlansker
approved these changes
Nov 27, 2023
- reduced use of reflection - documented use - fixed minor bug
hgschmie
force-pushed
the
jdbi-repositories_improvements
branch
from
5e3bc12
to
1cb5d6f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As English in not my first language, please check spelling and grammar.
Made some improvements as suggested by @stevenschlansker
(I fudged my rebase, so I decided to make a new branch instead)