Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for notation position of progress bar tracker value #180

Merged
merged 3 commits into from Aug 9, 2021
Merged

Added support for notation position of progress bar tracker value #180

merged 3 commits into from Aug 9, 2021

Conversation

ferryvg
Copy link
Contributor

@ferryvg ferryvg commented Jul 27, 2021

Proposed Changes

  • Added NotationPosition field to progress.Units struct
  • Added UnitsNotationPositionBefore (as default) and UnitsNotationPositionAfter constants
  • Changes in progress.Units.Sprint method

@jedib0t
Copy link
Owner

jedib0t commented Aug 9, 2021

@ferryvg Can you please fix the linter issues?

@coveralls
Copy link

coveralls commented Aug 9, 2021 •
edited

Pull Request Test Coverage Report for Build 1113814779

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1111855749: 0.0%
Covered Lines: 2967
Relevant Lines: 2967
💛 - Coveralls

@ferryvg
Copy link
Contributor Author

ferryvg commented Aug 9, 2021

@jedib0t it's done

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jedib0t jedib0t merged commit f0fe8f9 into jedib0t:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferryvg @jedib0t @coveralls