From 47e9604dee914bdb9418605f20ac5c7ca6de2e6c Mon Sep 17 00:00:00 2001 From: Andy Edwards Date: Tue, 20 Jul 2021 15:02:47 -0500 Subject: [PATCH] docs(CONTRIBUTING.md): update required node versions Node ^12.20 || >=14.13 is now required because there are MJS modules in the project that have named imports from CJS modules. Support for doing this was only added in 14.13.0 and backported to 12.20.0: https://github.com/nodejs/node/pull/35249#issuecomment-742554710 --- CONTRIBUTING.md | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 169dd2e8b475..6bd12d4ab44b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,17 +1,15 @@ --- -

- Setup - | - Running linting/tests - | - Writing tests - | - Debugging code - | - Internals +Setup +| +Running linting/tests +| +Writing tests +| +Debugging code +| +Internals

- --- # Contributing @@ -39,14 +37,14 @@ Feel free to check out the `#discussion`/`#development` channels on our [Slack]( ## Developing -*Node*: Check that Node is [installed](https://nodejs.org/en/download/) with version `^12.16 || >= 14`. You can check this with `node -v`. +_Node_: Check that Node is [installed](https://nodejs.org/en/download/) with version `^12.20 || >= 14.13`. You can check this with `node -v`. -*Yarn*: Make sure that Yarn 1 is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `1.19.0`. +_Yarn_: Make sure that Yarn 1 is [installed](https://classic.yarnpkg.com/en/docs/install) with version >= `1.19.0`. -*Make*: If you are running Windows 10, you'll need to do one of the following: +_Make_: If you are running Windows 10, you'll need to do one of the following: -* Clone the repository and run the commands inside [WSL 2](https://docs.microsoft.com/en-us/windows/wsl/install-win10). -* Install [Make for Windows](http://gnuwin32.sourceforge.net/packages/make.htm). +- Clone the repository and run the commands inside [WSL 2](https://docs.microsoft.com/en-us/windows/wsl/install-win10). +- Install [Make for Windows](http://gnuwin32.sourceforge.net/packages/make.htm). ### Setup @@ -224,7 +222,12 @@ Other than normal Babel options, `options.json` can contain other properties to ```jsonc // options.json example { - "plugins": [["@babel/plugin-proposal-object-rest-spread", { "useBuiltIns": "invalidOption" }]], + "plugins": [ + [ + "@babel/plugin-proposal-object-rest-spread", + { "useBuiltIns": "invalidOption" } + ] + ], "throws": "@babel/plugin-proposal-object-rest-spread currently only accepts a boolean option for useBuiltIns (defaults to false)" } ```