Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that the vendor directory must be excluded #69

Open
AnyOldName3 opened this issue Dec 14, 2023 · 1 comment
Open

Document that the vendor directory must be excluded #69

AnyOldName3 opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@AnyOldName3
Copy link

This line https://github.com/jeffreytse/jekyll-deploy-action/blob/master/entrypoint.sh#L22 causes Bundler to install gems to the vendor subdirectory of the working directory so gems can be cached. However, it also means Jekyll will attempt to include files from gems in the site, potentially leading to errors like https://hjerpbakk.com/blog/2020/05/25/your-site-could-not-be-built for a site that built just fine outside of this action.

Documenting that the vendor directory needs adding to the site's exclude list would be helpful for avoiding and diagnosing this kind of problem.

@jeffreytse jeffreytse self-assigned this Apr 3, 2024
@jeffreytse jeffreytse added the documentation Improvements or additions to documentation label Apr 3, 2024
@jeffreytse
Copy link
Owner

Hi @AnyOldName3

I'm so sorry for the late reply as my busyness. Thanks for your kind advice, I will try to work on it ASAP.

Thanks & Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants