Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched xml_escape for <![CDATA[]]> for post content #332

Merged
merged 3 commits into from Jan 1, 2022

Conversation

michaelnordmeyer
Copy link
Contributor

See "Handling Atom Text and Content Constructs" (http://www.xml.com/pub/a/2005/12/07/handling-atom-text-and-content-constructs.html) for an explanation why this is valid and the recommended way of handling unescaped content in XML documents.

TL;DR: Much nicer to read if you for some reason have a look at the feed.xml source. Also less parsing on the client-side.

See "Handling Atom Text and Content Constructs" (http://www.xml.com/pub/a/2005/12/07/handling-atom-text-and-content-constructs.html) for an explanation why this is valid and the recommended way of handling unescaped content in XML documents.

TL;DR: Much nicer to read if you for some reason have a look at the feed.xml source. Also less parsing on the client-side.
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some tests fixed, but 👍

@michaelnordmeyer
Copy link
Contributor Author

I found just one failed test and fixed it.

@parkr
Copy link
Member

parkr commented Jan 1, 2022

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 1ac64bc into jekyll:master Jan 1, 2022
jekyllbot added a commit that referenced this pull request Jan 1, 2022
@jekyll jekyll locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants