Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.0 to CI #337

Merged
merged 5 commits into from Feb 19, 2021
Merged

Add Ruby 3.0 to CI #337

merged 5 commits into from Feb 19, 2021

Conversation

oturpe
Copy link
Contributor

@oturpe oturpe commented Feb 18, 2021

jekyll-feed will be included in Fedora 34 which will also use Ruby 3.0
as system Ruby interpreter. This combination is known to work, so it
would make sense to add it to CI.

@oturpe
Copy link
Contributor Author

oturpe commented Feb 18, 2021

Both Travis and AppVeyor are in use. The reason for this is unclear for me. I updated only Travis, because it had newer versions of everything. Should also AppVeyor be updated?

@oturpe
Copy link
Contributor Author

oturpe commented Feb 19, 2021

Oh, build for Ruby 3.0 failed due to missing rss gem. In Ruby 3.0, it became a bundled gem, thus it needs to be added as a dependency. I will fix that in this pull request. On the other hand, I see that there is some GitHub actions work going on the master branch, does that mean that Travis on its way out?

@DirtyF
Copy link
Member

DirtyF commented Feb 19, 2021 •
edited

@oturpe yes the plan is to move all our CI to GitHub Actions, but we still need to test 3.9 and 4.2

@oturpe
Add Ruby 3.0 to CI
edc2dc9 
jekyll-feed will be [included in Fedora 34][pkg] which will also use [Ruby 3.0
as system Ruby interpreter][ruby]. This combination is known to work, so it
would make sense to add it to CI.

In Ruby 3.0, `rss` moved from default gem to a bundled gem, thus it must be
added as dependency when it is used.

[pkg]: https://src.fedoraproject.org/rpms/rubygem-jekyll-feed
[ruby]: https://fedoraproject.org/wiki/Changes/Ruby_3.0
@oturpe
Copy link
Contributor Author

oturpe commented Feb 19, 2021

Rss gem fix added. Very common problem in Ruby 3.0 migration, because there was no warning in Ruby 2.7. Luckily, easy to fix too.

You can either merge this pull request, or just take the good parts if that fits the plan better.

ashmaroli
ashmaroli requested changes Feb 19, 2021
View reviewed changes
jekyll-feed.gemspec Outdated Show resolved Hide resolved
DirtyF
DirtyF reviewed Feb 19, 2021
View reviewed changes
jekyll-feed.gemspec Outdated Show resolved Hide resolved
@oturpe
Copy link
Contributor Author

oturpe commented Feb 19, 2021

The solution for the rss problem that went is better than my proposal. Ruby 3.0 is now included in ci, so what I was trying to achieve with this pull request has been achieved. Thank you for your effort!

@ashmaroli
Copy link
Member

Thank you @oturpe
@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit be3c94a into jekyll:master Feb 19, 2021
jekyllbot added a commit that referenced this pull request Feb 19, 2021
@jekyllbot
Update history to reflect merge of #337 [ci skip]
6d4913f
@jekyll jekyll locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oturpe @DirtyF @ashmaroli @jekyllbot