New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for sassc #140
Conversation
Thank you for getting the ball rolling towards a major version bump, @ntkme. I would like to see the Readme explicitly document the different out-of-the-box behaviors from v2.x and v3.x by the time this is ready for merge. |
@ashmaroli @parkr Added a migration section in README and ready for initial review. |
@ntkme Is there a test for inline sourcemap with Base64 data..? I can't seem to find it.. if there is no test, it needs to be added as it is a new feature. |
@ashmaroli Finally got sometime to add tests around inline sourcemap. |
@ntkme I apologise for not telling you this earlier but I think you should extract the inline-sourcemap related changes to another branch and have it merged via a separate pull request that is meant to be merged at a future date. |
@ashmaroli Took it out. |
Is the following code meant to be in the current PR? # Returns a source mapping url for given source-map.
def source_mapping_url(source_map)
if associate_page_failed?
"data:application/json;base64,#{Base64.strict_encode64(source_map)}"
else
Addressable::URI.encode(sass_page.basename + ".css.map")
end
end This looks like another enhancement to me.. |
@ashmaroli Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @ntkme |
Per above comment and discussion in #137, this PR drops support for sassc.
Changes
required_ruby_version
to>= 2.6.0
as it is a requirement forsass-embedded
.add_charset
option. Whether to add@charset
or not will now be automatically determined based onassociate_page_failed?
. If a page is associated, sass will automatically add@charset
or BOM if output contains any non-ASCII character. Otherwise, e.g. when called viasassify
/scssify
filters,@charset
or BOM will be omitted.sassify
/scssify
filters if source map is enabled.