Remove extra newline in css output #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
reviewed
Dec 8, 2022
lib/jekyll/converters/scss.rb
Outdated
|
|
||
| if sourcemap_required? | ||
| source_map = process_source_map(output.source_map) | ||
| generate_source_map_page(source_map) | ||
|
|
||
| if (sm_url = source_mapping_url) | ||
| result << "\n/*# sourceMappingURL=#{sm_url} */" | ||
| result += "\n/*# sourceMappingURL=#{sm_url} */" |
There was a problem hiding this comment.
I would like to have blank line before the link to the sourcemap to serve as a visual separation from CSS rules, especially when the rules are compact.
Suggested change
| result += "\n/*# sourceMappingURL=#{sm_url} */" | |
| result += "\n\n/*# sourceMappingURL=#{sm_url} */" |
There was a problem hiding this comment.
@ashmaroli Updated to be consistent with dart-sass: https://github.com/sass/dart-sass/blob/1e211d640a86160910a53de600e3a55f70409470/lib/src/executable/compile_stylesheet.dart#L179-L180
ashmaroli
approved these changes
Dec 8, 2022
|
Thanks @ntkme |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an extra new line in the css output to make it fully consistent with dart-sass. Previously, a newline is explicitly added to make output compatible with sassc so that the same test case would pass for both implementations. Now the support for sassc is dropped, there is no need to keep that extra newline.
Although this is more of a cosmetic thing, it also has a small performance benefit of avoid copying the frozen string returned from protobuf when source map is disabled.