Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close stale issues as "not planned" #14

Closed
ashmaroli opened this issue May 22, 2022 · 4 comments · Fixed by #27
Closed

Close stale issues as "not planned" #14

ashmaroli opened this issue May 22, 2022 · 4 comments · Fixed by #27
Labels
has-pull-request

Comments

@ashmaroli
Copy link
Member

GitHub recently enhanced their issues feature with closed reasons, with the default reason being complete.

When JekyllBot closes stale issues, they get complete as the reason instead of not planned as GitHub expects.

It would be great if JekyllBot would provide the correct reason via the dispatch webhook.
@parkr
Copy link
Member

parkr commented Jun 20, 2022

This requires an upgrade to go-github which I did in #18, but when I went looking for this in the API, it doesn't appear to be present. Do you know if there is API support for this feature?

@parkr
Copy link
Member

parkr commented Jun 20, 2022

I emailed GitHub Support about this.

@parkr
Copy link
Member

parkr commented Aug 21, 2022

I added this in google/go-github#2395. Once it’s released (if not already), then we can pull it in!

@parkr
Copy link
Member

parkr commented Aug 21, 2022

Looks like we need to upgrade to v46, then change the request to set this field.

@parkr parkr mentioned this issue Aug 21, 2022
Merged
@parkr parkr closed this as completed in #27 Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close with issue reason 'not_planned' jekyll/jekyllbot
3 participants
@parkr @jekyllbot @ashmaroli