Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't warn about partially filled out times #277

Open
doobry-systemli opened this issue Nov 1, 2019 · 6 comments · Fixed by #279
Open

Doesn't warn about partially filled out times #277

doobry-systemli opened this issue Nov 1, 2019 · 6 comments · Fixed by #279
Labels
bug ux user experience

Comments

@doobry-systemli
Copy link

When entering times for the selected dates, there's two usability bugs:

  1. Partially entered times are accepted as valid but withdrawn in next step
  2. Selecting "Copy and paste times of first day to all other" with partially entered times doesn't create a warning, even though nothing happens

croodle_datepicker

@jelhan
Copy link
Owner

jelhan commented Nov 1, 2019

This is a tough one. Browser does not set input's value for an <input type="time"> if user enters only parts of a time. I'm not sure if there is any way to distinguish if the input is empty or partly entered. https://jsbin.com/pikabowoyo/edit?html,js,output

@jelhan jelhan added the ux user experience label Nov 1, 2019
@geor-g
Copy link

geor-g commented Nov 1, 2019

I'm not sure how the following would relate to the UX, but would using multiple fields work?

@sappor0
Copy link
Contributor

sappor0 commented Nov 1, 2019

Hm. Even though I'm a big fan of using the browser native input elements as much as possible. Together with #238 this kind of begs the question whether to switch to some form of custom element for date and time inputs. 😿

@jelhan
Copy link
Owner

jelhan commented Nov 2, 2019

I've asked on StackOverflow and got a solution after a few minutes. The input is invalid if partially filled. 🎉

@jelhan
Copy link
Owner

jelhan commented Nov 3, 2019

Reopen as the fix does not work in Firefox on Desktop. 😞

User interfaces of mobile Chrome, mobile Firefox and Edge prevent filling in a partially time. Safari (Desktop) and IE 11 does not support <input type="time">. Haven't had the chance to test iOS Safari yet.

@jelhan jelhan reopened this Nov 3, 2019
@doobry-systemli
Copy link
Author

Yeah, just experienced the same: it doesn't work as intended in Firefox on Desktop 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ux user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants