Fix update of expired items #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davseby
reviewed
Mar 12, 2024
cache_test.go
Outdated
| @@ -1212,3 +1212,29 @@ func addToCache(c *Cache[string, string], ttl time.Duration, keys ...string) { | |||
| c.items.expQueue.push(elem) | |||
| } | |||
| } | |||
|
|
|||
| func TestUpdateExpired(t *testing.T) { | |||
There was a problem hiding this comment.
This is not how we write unit tests. The test cases should be incorporated into the functions named after the methods that were changed.
There was a problem hiding this comment.
To be honest I don't see much value in this test at all, it's too specific. But this test was crucial for me to reproduce issue I was suspecting and validate solution. Should I relocate it or should I just drop it?
There was a problem hiding this comment.
Test_Cache_set should be expanded to include a test for overwriting an expired item.
Snawoot
force-pushed
the
fix_stale_update
branch
from
2ffa4e8
to
a34b07b
Compare
Signed-off-by: Vladislav Yarmak <vladislav-ex-src@vm-0.com>
Signed-off-by: Vladislav Yarmak <vladislav-ex-src@vm-0.com>
Snawoot
force-pushed
the
fix_stale_update
branch
from
a34b07b
to
9e82ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #123
Extends
getmethod to return expired items tosetmethod in order to avoid second insertion into expiration queue.