Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third party repository detection #299

Open
alecharp opened this issue Apr 20, 2023 · 7 comments · May be fixed by #323
Open

Third party repository detection #299

alecharp opened this issue Apr 20, 2023 · 7 comments · May be fixed by #323
Labels
enhancement New feature or request probe Related to probe implementation

Comments

@alecharp
Copy link
Collaborator

Description

Some plugins are using third party repositories to resolve dependencies.
Being able to detect those could be of interest for the infra team.

Idea from @lemeurherve and @dduportal

@alecharp alecharp added enhancement New feature or request probe Related to probe implementation labels Apr 20, 2023
@DanielS01ss
Copy link

Hi!
I would love to work on this issue

@Jagrutiti Jagrutiti self-assigned this May 30, 2023
@Jagrutiti
Copy link
Member

Jagrutiti commented May 31, 2023

Hi everyone,

If a <url> in pom.xml does not start with https://repo.jenkins-ci.org/ui/packages, does that mean it is a third-party package?

Should this be my approach to detect a third-party package?

@alecharp
Copy link
Collaborator Author

alecharp commented May 31, 2023

@DanielS01ss I'm sorry, but as part of the GSoC project, it would be better if you could find another issue to work one. Those without the project GSoC 2023 are up for grab.

@Jagrutiti no really. This because you are project.url which should point to the plugin repository (or somewhere in the repository) for the plugin documentation migration. But you have project.repositories which should be a list of 1 or more elements. What we want is to detect if a plugin is using a repository which is not https://repo.jenkins-ci.org/public.

Please see https://maven.apache.org/guides/introduction/introduction-to-repositories.html and sub-documentation to have more details.

The problem is not third-party packages. The problem is getting those packages from a place we (Jenkins community) have no knowledge about.

Note: please reuse what exists to parse the pom.xml, aka use a library to read the POM file.

@Jagrutiti Jagrutiti linked a pull request Jun 1, 2023 that will close this issue
7 tasks
@alecharp
Copy link
Collaborator Author

alecharp commented Jun 5, 2023

After discussing with @lemeurherve, we need to track everything that is downloaded outside of repo.jenkins-ci.org. This also includes pluginRepositories.

@Jagrutiti
Copy link
Member

To continue the work further, learning more about effective-pom and how to run maven from java could prove helpful.

@AayushSaini101
Copy link
Contributor

@alecharp Please add GSOC label

@alecharp alecharp added gsoc Do not take / work on GSoC tickets outside of GSoC context. and removed gsoc Do not take / work on GSoC tickets outside of GSoC context. labels Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request probe Related to probe implementation
Projects
No open projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

5 participants