Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-18884] People View plugin #3830

Closed
daniel-beck opened this issue Mar 23, 2024 · 13 comments
Closed

[JENKINS-18884] People View plugin #3830

daniel-beck opened this issue Mar 23, 2024 · 13 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@daniel-beck
Copy link
Contributor

daniel-beck commented Mar 23, 2024

Repository URL

https://github.com/daniel-beck/people-view-plugin

New Repository Name

people-view-plugin

Description

Extracting the current core feature into a plugin (without split/detached implied dependency).

Upstream is jenkinsci/jenkins#9060

JENKINS-18884

GitHub users to have commit permission

@daniel-beck

Jenkins project users to have release permission

danielbeck

Issue tracker

GitHub issues

@daniel-beck daniel-beck added the hosting-request Request to host a component in jenkinsci label Mar 23, 2024
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.28.0)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Mar 23, 2024
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added the bot-check-complete Automated hosting checks passed label Mar 23, 2024
@daniel-beck daniel-beck added the on-hold The issue/PR cannot proceed until the actor adding this label removes it label Mar 23, 2024
@jenkins-cert-app
Copy link
Collaborator

❌ Jenkins Security Scan failed.
The Security team was notified about this.

@Wadeck
Copy link
Contributor

Wadeck commented Mar 25, 2024

FTR error came from

[ERROR] Non-resolvable import POM: The following artifacts could not be resolved: org.jenkins-ci.main:jenkins-bom:pom:2.451-SNAPSHOT (absent)

As there is an upstream PR, it's expected :)

@NotMyFault
Copy link
Member

LGTM so far, but needs a mvn spotless:apply to succeed themvn clean verify package goals.

@daniel-beck
Copy link
Contributor Author

/request-security-scan

@jglick
Copy link
Contributor

jglick commented Mar 27, 2024

@daniel-beck BTW you can specify an incremental (rc) version for jenkins.version. You will not be able to cut a release until it is switched to a regular version (something present in releases).

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Mar 27, 2024
@daniel-beck
Copy link
Contributor Author

@jglick Thanks for the reminder.

@timja
Copy link
Member

timja commented Mar 27, 2024

/hosting host

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@daniel-beck daniel-beck removed the on-hold The issue/PR cannot proceed until the actor adding this label removes it label Mar 28, 2024
@timja
Copy link
Member

timja commented Mar 28, 2024

/hosting host

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/people-view-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

Welcome aboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

7 participants