Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devpod watch.sh location? #1147

Closed
sdoxsee opened this issue Jun 26, 2018 · 3 comments
Closed

Devpod watch.sh location? #1147

sdoxsee opened this issue Jun 26, 2018 · 3 comments

Comments

@sdoxsee
Copy link

sdoxsee commented Jun 26, 2018

I used 'jx create spring' and have a git repository and everything else. However, when i do 'jx create devpod --sync --reuse' I get into the pod but there is no watch.sh script that builds my image to test (as per https://jenkins-x.io/developing/devpods/#example-workflow-with-an-existing-project). At what point does the watch.sh appear or is that not part of the spring project and only quickstart? Thanks!

Update: Just found more documentation

So once the skaffold dev -p dev (what watch.sh does)

Now I can see it built and I can go to the url. (NOTE: still not sure why there was no watch.sh...perhaps this was removed and the documentation needs updating)

However, it still doesn't seem to be watching my changes. Maybe the error below is why

skaffold dev -p dev
Starting build...
Sending build context to Docker daemon  17.49MB
Step 1/8 : FROM openjdk:8-jdk-slim
 ---> 954f983e50de
Step 2/8 : ENV PORT 8080
 ---> Using cache
 ---> 5d31b06d4fdd
Step 3/8 : ENV CLASSPATH /opt/lib
 ---> Using cache
 ---> 00396980b264
Step 4/8 : EXPOSE 8080
 ---> Using cache
 ---> 395efbf6caf0
Step 5/8 : COPY pom.xml target/lib* /opt/lib/
 ---> Using cache
 ---> 6448ae323e2b
Step 6/8 : COPY target/*.jar /opt/app.jar
 ---> Using cache
 ---> 40ae182925c2
Step 7/8 : WORKDIR /opt
 ---> Using cache
 ---> 7002287f565d
Step 8/8 : CMD java -jar app.jar
 ---> Using cache
 ---> ca20213eb1af
Successfully built ca20213eb1af
WARN[0000] run: build: build step: tagging image: Error parsing reference: "<no value>/sdoxsee/demo:ca20213eb1af650466af7c43345d9de579b992b368fbf4543bef0c4067552dea" is not a valid repository/tag: invalid reference format
Watching for changes...

must be my DOCKER_REGISTRY is undefined....tracking that down

@jstrachan
Copy link
Member

BTW I fixed the DOCKER_REGISTRY issue yesterday. If you do jx upgrade platform and delete and recreate your devpod jx delete devpod && jx create devpod it should be fine again.

On the watch.sh really those scripts were temporary hacks until skaffold did all the awesome via skaffold dev; though we've only watch.sh scripts in the quickstarts for node + go right now:

the aim is to move towards just using vanilla skaffold really. We're super close to moving back to the upstream skaffold now. Now the remaining known regression was fixed: GoogleContainerTools/skaffold#741

we just need the next release and we're good to go.

BTW we're hoping to use a slightly different approach to give a nice developer feedback for working with Java/Spring: #833

@sdoxsee
Copy link
Author

sdoxsee commented Jun 26, 2018

Thanks @jstrachan. Very helpful comment and super cool project. I'm enjoying the experience! I'll close this and look forward to the coming improvements. Cheers.

@sdoxsee sdoxsee closed this as completed Jun 26, 2018
@jstrachan
Copy link
Member

many thanks @sdoxsee and good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants