Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page object for the snippet generator #1492

Merged
merged 4 commits into from Mar 9, 2024
Merged

Add a page object for the snippet generator #1492

merged 4 commits into from Mar 9, 2024

Conversation

Comment on lines 35 to 36
button.click();
elasticSleep(500);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid introducing new POs with elastic sleep where they can be avoided.

if the callers are never going to call generate script more than once you can wait wait.until the textarea is not empty. (and add this fact to the javadoc)
if it is going to call it more than once with different options then it should be possible to get a before and wait until it is not the same.

@timja timja merged commit 4da234e into master Mar 9, 2024
24 checks passed
@timja timja deleted the po-extensions branch March 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants