Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility for new progressbar rendering #1493

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Feb 23, 2024

previously it was table, now it is a (theoretically it can also be div but not for the build history).
See jenkinsci/jenkins#8821

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

previously it was `table`, now it is `a` (theoretically it can also
be `div` but not for the build history.
@jtnord jtnord enabled auto-merge (squash) February 23, 2024 18:39
@raul-arabaolaza
Copy link
Contributor

None of the test failures here are new and were already falling in previous runs of master. So I believe this will need to be merged manually.

I am checking the test failures just in case I can find an easy fix as the root cause looks limited

@raul-arabaolaza
Copy link
Contributor

I found no relationship between this change and the test failures, this can be merged IMO.

@NotMyFault NotMyFault merged commit 0197512 into jenkinsci:master Feb 29, 2024
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants