Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define project.build.outputTimestamp #717

Open
basil opened this issue Apr 10, 2024 · 3 comments
Open

Define project.build.outputTimestamp #717

basil opened this issue Apr 10, 2024 · 3 comments

Comments

@basil
Copy link
Member

basil commented Apr 10, 2024

One issue blocking progress on jenkinsci/plugin-pom#919 is that we do not conform to https://maven.apache.org/guides/mini/guide-reproducible-builds.html by defining a project.build.outputTimestamp property.

@basil
Copy link
Member Author

basil commented Apr 12, 2024

It should be simple enough to configure the archetype as recommended in https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build for new plugins, but the real challenge associated with this task is to add the property to existing plugins that don't have automated release enabled (and where jenkinsci/incrementals-tools#104 would not apply).

@jglick
Copy link
Member

jglick commented May 7, 2024

So this issue is now limited to plugins using MRP? Then

if you use maven-release-plugin, you'll need version 3.0.0-M1 or later: it will automatically update the timestamp value in pom.xml during the release in the same commit that updates version,

implies that the archetype could just set this to some placeholder value (but then CD instructions ought to remind you to delete it).

At this point it would make more sense to preconfigure CD in the archetype, at least optionally.

@basil
Copy link
Member Author

basil commented May 7, 2024

but then CD instructions ought to remind you to delete it

@jglick Have you read the CD instructions you link to above to see whether they already contain the thing you think they ought to contain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants