Bundle antlr as core no longer provides it #148
Merged
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used my admin powers to replay the build with the |
|
PR build with |
timja
changed the title
timja
approved these changes
Nov 2, 2022
Thanks for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin consumes ANTLR 2 transitively, and excludes the JAR under the assumption that it is bundled in core. That assumption is no longer true as of jenkinsci/jenkins#7293, so this PR updates the baseline and removes the exclusion accordingly. I couldn't think of a way to prepare this plugin in advance, since if I just excluded the dependency while keeping the core baseline at its original value then Maven HPI plugin wouldn't bundle the JAR. But with this PR I confirmed the JAR does get bundled:
I am planning on merging jenkinsci/jenkins#7293 tomorrow toward 2.376, so this would need to be updated to the final released version and released at the same time. CC @timja